Rewrite: breakOut (fix #46) #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
reviewed
Jun 27, 2018
| val xs = List(1, 2, 3) | ||
|
|
||
| xs.collect{ case x => x }(breakOut): Set[Int] | ||
| xs.flatMap(x => List(x))(breakOut): Set[Int] |
There was a problem hiding this comment.
Can you also try with a sorted result? SortedSet[Int] for instance.
| xs.scanLeft(0)((a, b) => a + b)(breakOut): Set[Int] | ||
| xs.union(xs)(breakOut): Set[Int] | ||
| xs.updated(0, 1)(breakOut): Set[Int] | ||
| xs.zip(xs)(breakOut): Array[(Int, Int)] |
There was a problem hiding this comment.
Can you try with a Map[Int, Int]?
| op match { | ||
| case operatorsIterator(_) => "iterator" | ||
| case operatorsView(_) => "view" | ||
| case _ => throw new Exception("impossible") |
There was a problem hiding this comment.
Maybe add a comment referring to the definition of operatorSymbols, explaining why that makes that path impossible to reach?
|
@julienrf all comments addressed. |
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
version bumps, and modernize .travis.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.